[Webkit-unassigned] [Bug 173770] [WPE] Add env var WPE_USE_HEADLESS_VIEW_BACKEND

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173770

--- Comment #6 from Zan Dobersek <zan at falconsigh.net> ---
(In reply to Carlos Garcia Campos from comment #5)
> (In reply to Zan Dobersek from comment #4)
> > Comment on attachment 313722 [details]
> > Patch
> > 
> > We can't add a WPEBackend-mesa dependency to libWPEWebKit. I didn't account
> > for that.
> 
> Ah :-( Could you elaborate? what's the problem of making libWPEWebKit link
> to WPEBackend-mesa?
> 

Because other platforms can't use that, so it can't be depended on universally.

> > Same approach should be taken as with WKTR, creating a custom headless view
> > backend.
> 
> What do you mean? Using a different headless view backend that doesn't need
> WPEBackend-mesa?

We still use WPEBackend-mesa as a reference backend implementation, and depend on it for testing. There's no generic exportable interface, but it might make sense to look into creating one. But for now we have to leverage WPEBackend-mesa, just not as a hard-coded dependency of the main libWPEWebKit.so library.

What could be used for unit tests is basically a pass-through wpe_mesa_view_backend_exportable_dma_buf_client implementation. The export_dma_buf callback would only call wpe_mesa_view_backend_exportable_dma_buf_dispatch_frame_complete() and wpe_mesa_view_backend_exportable_dma_buf_dispatch_release_buffer(), and not bother with any other operation like we do in the WKTR HeadlessViewBackend.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170626/a09f52b4/attachment.html>