[Webkit-unassigned] [Bug 173714] Use window.internals instead of overridePreference to set WebCore settings in tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 23 03:52:42 PDT 2017


--- Comment #12 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
(In reply to Frédéric Wang (:fredw) from comment #11)
> > I'm a bit confused by these changes. I don't think
> > `internals.setEnableCaretBrowsing` exists. Perhaps
> > `internals.settings.setEnableCaretBrowsing` does?
> Indeed, it was a mistake. However, I tried setEnableCaretBrowsing locally
> and it still failed. There are other similar failures with undefined
> function even when the settings are in Settings.in but I'm not exactly sure
> what is the rule to automatically generate setter for boolean settings...

OK, I read too quickly your message yesterday. The name of the settings seems to be "caretBrowsingEnabled" which is what I tried locally yesterday. I did not notice that you were actually highlighting to the missing ".settings" which was indeed another error on my side. I'll try to upload an updated patch and see if it gives better results :-)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170623/ea6aa73a/attachment.html>

More information about the webkit-unassigned mailing list