[Webkit-unassigned] [Bug 173407] WTF::StringImpl::copyChars segfaults when built with GCC 7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 22 12:13:38 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=173407

--- Comment #11 from Darin Adler <darin at apple.com> ---
It’s great news if memcpy is now fast enough. I’d love to see my old awkward optimization removed if it no longer does any good.

In fact, I’m not sure we need a copyChars function at all. We could use memcpy directly as we once did, or even better ICU has u_memcpy if we want something that prevents the need to do "* sizeof(UChar)" at each call site. As long as u_memcpy has great performance too; presumably it expands into memcpy as an inline.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170622/5f375d17/attachment.html>


More information about the webkit-unassigned mailing list