[Webkit-unassigned] [Bug 173714] Use window.internals instead of overridePreference to set WebCore settings in tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 22 11:32:54 PDT 2017


--- Comment #11 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
(In reply to Joseph Pecoraro from comment #10)
> With this change you should be able to eliminate any no longer used settings
> from InjectedBundle::overrideBoolPreferenceForTestRunner.
> We try to include a description of the change here in the ChangeLog if it is
> not immediately obvious from the title.

Right. This was just an experimental patch to see the results.

> > LayoutTests/accessibility/gtk/caret-browsing-select-focus.html:17
> > +if (window.testRunner && window.internals) {
> > +  internals.setEnableCaretBrowsing(true);
> I'm a bit confused by these changes. I don't think
> `internals.setEnableCaretBrowsing` exists. Perhaps
> `internals.settings.setEnableCaretBrowsing` does?

Indeed, it was a mistake. However, I tried setEnableCaretBrowsing locally and it still failed. There are other similar failures with undefined function even when the settings are in Settings.in but I'm not exactly sure what is the rule to automatically generate setter for boolean settings...

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170622/e3b448b2/attachment.html>

More information about the webkit-unassigned mailing list