[Webkit-unassigned] [Bug 173709] New: [WPE] Downloads never have a web view associated in WPE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173709

            Bug ID: 173709
           Summary: [WPE] Downloads never have a web view associated in
                    WPE
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit WPE
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cgarcia at igalia.com
                CC: bugs-noreply at webkitgtk.org

PageClientImpl::handleDownloadRequest is not implemented in WPE. This causes some failures in the download unit tests:

TEST: bin/TestWebKitAPI/WPE/TestDownloads... (pid=20583)
  /wpe/Downloads/local-file:                                           OK
  /wpe/Downloads/overwrite-destination-allowed:                        OK
  /wpe/Downloads/overwrite-destination-disallowed:                     OK
  /wpe/Downloads/local-file-error:                                     OK
  /wpe/Downloads/remote-file:                                          OK
  /wpe/Downloads/remote-file-error:                                    OK
  /wpe/Downloads/policy-decision-download:                             **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:621:void testPolicyResponseDownload(PolicyResponseDownloadTest*, gconstpointer): assertion failed: (test->m_webView == webkit_download_get_web_view(test->m_download.get()))
FAIL
GTester: last random seed: R02Sa8d9d000d6db4269850e6c1f4a34d47c
(pid=20692)
  /wpe/Downloads/policy-decision-download-cancel:                      **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:640:void testPolicyResponseDownloadCancel(PolicyResponseDownloadTest*, gconstpointer): assertion failed: (test->m_webView == webkit_download_get_web_view(test->m_download.get()))
FAIL
GTester: last random seed: R02S8a053b0c2c679fe83edfdde89d0606b7
(pid=20727)
  /wpe/Downloads/mime-type:                                            OK
  /wpe/WebKitWebView/download-uri:                                     **
ERROR:/home/cgarcia/src/git/gnome/WebKit-WPE/Tools/TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:568:void testWebViewDownloadURI(WebViewDownloadTest*, gconstpointer): assertion failed: (test->m_webView == webkit_download_get_web_view(download.get()))
FAIL
GTester: last random seed: R02Sa218af78bd296a6c027f85e8642edab9
(pid=20771)
FAIL: bin/TestWebKitAPI/WPE/TestDownloads

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170622/75c00822/attachment-0001.html>