[Webkit-unassigned] [Bug 173691] New: pretty patch doesn't show image diffs with newer versions of git

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173691

            Bug ID: 173691
           Summary: pretty patch doesn't show image diffs with newer
                    versions of git
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: lforschler at apple.com

Tools/Scripts/webkit-patch pretty-diff or Tools/Scripts/show-pretty-diff doesn't generate images anymore with newer versions of git. Instead of the image an error appears saying:

Error running git apply --directory=/tmp
with patch:
diff --git a/PrettyPatch20170622-32032-41lcvr.bin b/PrettyPatch20170622-32032-41lcvr.bin
new file mode 100644
index 0000000000000000000000000000000000000000..e03210de3ed0f0bfe3ca9a4fe73386d7ed93fb73
GIT binary patch
literal 3278
zcmeAS at N?(olHy`uVBq!ia0y~yU{+vYV2a>i0*Z)=h^hlA%@Ws$lH`ok<m}?oTn5WT
zBLhn_Ln9Ll!?eWYM58nV6B9Ed^Q1H*1H)8{By)$IF1LZ2*pj^6T^Rm@;DWu&Co?ec
z_<6cGhE&XXd-q`O?Fa_fiw_-mmnd!IxNeZ^vQqhMz}Y3e_OB%t9+ZrK>HWzvTIxu2
zT+O6wM#p||Gc at r3{qgbf5BdMKyJZ;|;wK+qV(8%1VQ83v!MKt6{?I0!?{^p(K5$H`
z7kt...
error: invalid path '/tmp/PrettyPatch20170622-32032-41lcvr.bin'


This "error: invalid path" is caused because git >= 2.3.3 added an extra security check enabled by default that forbids git apply to work on files outside of the working area.

To return back to the previous behaviour the argument --unsafe-paths can be passed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170622/c9eada6f/attachment.html>