[Webkit-unassigned] [Bug 173551] [Cocoa] implement URLSession:task:needNewBodyStream: delegate method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173551

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 313308
  --> https://bugs.webkit.org/attachment.cgi?id=313308
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313308&action=review

>> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:154
>> +    auto* body = networkDataTask->firstRequest().httpBody();
> 
> NSURLSessionTask has currentRequest

Ah, we do want the http body of the first request, even if redirected.  This is an HTTP POST request.

> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:160
> +    // FIXME: Is there a problem if some files are different in size since the original sizing?

I think if someone modifies a file as we are uploading it they're going to have a bad time anyways.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170619/e4145b14/attachment.html>