[Webkit-unassigned] [Bug 173546] [WPE] Add initial implementation of glib API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173546

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Zan Dobersek from comment #2)
> Comment on attachment 313287 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=313287&action=review
> 
> > Source/WebKit2/UIProcess/API/glib/WebKitUIClient.cpp:167
> > +        // FIXME: I guess this is actually the view size in WPE. We need more refactoring here.
> > +        return { 800, 600 };
> 
> This should return a (0,0)x(0,0) rect for now. Also, this would be strange
> if it compiled, since you only specify the size to initialize a FloatRect.

I had { } and changed it right before submitting the patch to provide a useful value, but forgot it's not a size, but a rectangle :-P

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170619/d9add92a/attachment-0001.html>