[Webkit-unassigned] [Bug 173468] Crash due to infinite recursion via FrameSelection::updateAppearanceAfterLayout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 16 18:46:20 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #313075|review?                     |review+
              Flags|                            |

--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 313075
  --> https://bugs.webkit.org/attachment.cgi?id=313075

View in context: https://bugs.webkit.org/attachment.cgi?id=313075&action=review

r=me with the timer in FrameSelection.

> Source/WebCore/ChangeLog:11
> +        because itmay cause another call to resolveStyle. We have some cases where the style

Nit: it *may.

> Source/WebCore/page/FrameView.cpp:350
> +    m_selectionAppearanceUpdateTimer.stop();

I think it's cleaner to add this timer in FrameSelection.

> LayoutTests/editing/selection/updateAppearanceAfterLayout-recursion.html:14
> +link.setAttribute("href", "data:text/css,"+Math.random());

It seems unnecessary to use Math.random()

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170617/9f590623/attachment.html>

More information about the webkit-unassigned mailing list