[Webkit-unassigned] [Bug 173421] REGRESSION(r218325): [GTK] Runtime critical warnings running layout tests that show a popup menu

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 15 11:23:43 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=173421

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 312986
  --> https://bugs.webkit.org/attachment.cgi?id=312986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312986&action=review

Any warning ought to cause tests to fail :/ but it probably doesn't work that way currently.

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:211
> +    if (WEBKIT_IS_WEB_VIEW(m_viewWidget))
> +        return WebKitPopupMenu::create(m_viewWidget, page);
> +    return WebPopupMenuProxyGtk::create(m_viewWidget, page);

It merits a comment to explain the difference, don't you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170615/304ae313/attachment-0001.html>


More information about the webkit-unassigned mailing list