[Webkit-unassigned] [Bug 173407] WTF::StringImpl::copyChars segfaults when built with GCC 7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173407

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jfbastien at apple.com,
                   |                            |utatane.tea at gmail.com

--- Comment #3 from Yusuke Suzuki <utatane.tea at gmail.com> ---
(In reply to Konstantin Tokarev from comment #1)
> I've run JSC benchmarks on Linux with GCC 7.1, performance results were
> neutral after change of copyChars to do just memcpy

I like to use memcpy if it does not hurt performance.

Just out of curiosity, I wonder if we can use bitwise_cast here instead of reinterpret_cast.

Maybe, JF knows much about strict-aliasing, type punning and memcpy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170615/18739953/attachment.html>