[Webkit-unassigned] [Bug 172905] [GTK] Add API to allow overriding popup menus

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172905

--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #8)
> Comment on attachment 311960 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311960&action=review
> 
> Nice work, as usual.

Thanks.

> > Source/WebKit2/UIProcess/API/gtk/WebKitPopupMenu.h:29
> > +class WebKitPopupMenu final : public WebPopupMenuProxyGtk {
> 
> I'm confused by your decision to make a subclass of WebPopupMenuProxyGtk,
> and especially by your decision to not include "Proxy" in the name of the
> class. It's quite unclear that this object is a UI proxy for a web process
> object. Can you elaborate on why you chose this design?

I just followed what we already do for the context menu, I don't remember why i did it that way for the context menu, though.

> Would it be better for WebKitPopupMenu to contain a WebPopupMenuProxyGtk
> member variable rather than to inherit from it, as I suspect, or would this
> require too much extra code and indirection?

I don't see why it would be better, but worse neither.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:-256
> > -    void (*_webkit_reserved3) (void);
> 
> Running out of space for more virtual signals... I think we'll be hitting
> our limit within the next couple of years. Oh well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170615/19b84c1c/attachment.html>