[Webkit-unassigned] [Bug 173357] Add API::InjectedBundle::Client

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 14 23:27:45 PDT 2017


--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #6)
> (In reply to Matt Lewis from comment #4)
> > These API tests are timing out after this revision on macOS:
> > 
> > WebKit2.AttributedSubstringForProposedRangeWithImage
> > WebKit2.ContextMenuDownloadHTMLDownloadAttribute
> > WebKit2.ContextMenuDownloadHTMLDownloadAttributeWithSlashes
> > WebKit2.DidNotHandleKeyDown
> > WebKit2.FirstResponderScrollingPosition
> > WebKit2.ScrollByLineCommands
> > WebKit2.SpacebarScrolling
> So, EWS runs layout tests but not api tests? I'm sorry about these failures,
> I'll investigate them.

So, those tests are the only ones that use createContextWithInjectedBundle() directly, they are not named tests, which means they don't call WKBundleSetClient(). I've checked the patch and I forgot to initialize the client in InjectedBundle constructor, so it must be it, but I haven't checked it yet. I'll try to test it in a macOS to be sure.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170615/e1eab923/attachment.html>

More information about the webkit-unassigned mailing list