[Webkit-unassigned] [Bug 173382] New: WebAssembly: remove empty test files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 14 12:59:28 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=173382
Bug ID: 173382
Summary: WebAssembly: remove empty test files
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: JavaScriptCore
Assignee: webkit-unassigned at lists.webkit.org
Reporter: jfbastien at apple.com
CC: fpizlo at apple.com, jfbastien at apple.com,
keith_miller at apple.com, mark.lam at apple.com,
msaboff at apple.com, sbarati at apple.com
The following files:
JSTests/wasm/function-tests/call-indirect-params.js
JSTests/wasm/function-tests/call-indirect.js
JSTests/wasm/js-api/call-indirect-results.js
Were changed to empty files in https://trac.webkit.org/changeset/209771
They were testing call-indirect with the wrong semantics, before we implemented tables. That change implemented tables and therefore removed the erroneous tests.
We have a few tests for call_indirect which already do the right thing:
JSTests/wasm/function-tests/context-switch.js
JSTests/wasm/function-tests/exceptions.js
JSTests/wasm/function-tests/grow-memory-2.js
JSTests/wasm/function-tests/stack-overflow.js
JSTests/wasm/function-tests/table-basic-2.js
JSTests/wasm/function-tests/table-basic.js
JSTests/wasm/js-api/call-indirect.js
JSTests/wasm/js-api/table.js
JSTests/wasm/js-api/unique-signature.js
JSTests/wasm/js-api/wrapper-function.js
I also just imported the updated spec tests which, among other things, test call_indirect:
core/br.wast
core/br_table.wast
core/call_indirect.wast
core/func.wast
core/func_ptrs.wast
core/imports.wast
core/left-to-right.wast
core/linking.wast
core/nop.wast
core/return.wast
core/typecheck.wast
core/unreachable.wast
So I think it's OK to just delete the tests which should just have been deleted back when tables were added.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170614/7d93084e/attachment.html>
More information about the webkit-unassigned
mailing list