[Webkit-unassigned] [Bug 173362] Add API::InjectedBundle::ResourceLoadClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173362

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Alex Christensen from comment #2)
> Comment on attachment 312884 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312884&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:336
> > -    page.initializeInjectedBundleResourceLoadClient(&client.base);
> > +    WKBundlePageSetResourceLoadClient(toAPI(&page), &client.base);
> 
> I'm not sure about this change.  From API objects I think we want to call
> C++ methods, not use the C API.

But the C API is used there, mixing both is what caused this. If you prefer to use the C++ API, then this should be migrated to use API::InjectedBundle::ResourceLoadClient the same way we are doing for all our clients in the GTK+ API.

> > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:353
> > -        _page->initializeInjectedBundleResourceLoadClient(nullptr);
> > +        WKBundlePageSetResourceLoadClient(toAPI(_page.get()), nullptr);
> 
> ditto

Thanks for all the reviews, btw!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170614/a98c0f02/attachment-0001.html>