[Webkit-unassigned] [Bug 173266] API clients should not be passed by value to the setters

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 14 08:31:14 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=173266

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #14 from Michael Catanzaro <mcatanzaro at igalia.com> ---
I haven't looked at this closely, and maybe my question is obviously wrong, but here goes: why std::unique_ptr<API::InjectedBundle::EditorClient>&& and not just API::InjectedBundle::EditorClient&&? There's no polymorphism here, so is the pointer type really needed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170614/0138fb02/attachment-0001.html>


More information about the webkit-unassigned mailing list