[Webkit-unassigned] [Bug 173311] Do not mix C and C++ API error constants

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 14 08:26:38 PDT 2017


--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Darin Adler from comment #7)
> If there are two sets of constants, that must be identical, what keeps them
> in sync? If nothing else, should we write static_assert statements that
> check that they are equal?

I think we should make WKErrorGetErrorCode return the value using a switch and checking the API::Error value, even if they are currently the same values. That's what we do in the GTK+ API implementation. I'll do it in a follow up if you agree.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170614/11fdc6ed/attachment.html>

More information about the webkit-unassigned mailing list