[Webkit-unassigned] [Bug 173355] [GTK] Use API::InjectedBundle::EditorClient in WebKitWebEditor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173355

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 312869
  --> https://bugs.webkit.org/attachment.cgi?id=312869
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312869&action=review

>> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:85
>> +    void didChangeSelection(WebPage&, StringImpl* /*notificationName*/) override
> 
> Consider UNUSED_PARAM(notificationName), or just not listing the argument name.

For what it’s worth, I consider commenting out the name to be better than UNUSED_PARAM. I see UNUSED_PARAM as a necessary evil that we try to avoid, since it doesn’t even work -- it silences the warning, but doesn’t prevent use of the thing it marks as "unused"! But maybe we don’t have consensus on that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170614/b77419a5/attachment.html>