[Webkit-unassigned] [Bug 173302] REGRESSION (r217997): mint.com header renders incorrectly when initially loaded

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 13 13:28:24 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=173302

--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #8)
> > fixes the issue. Simon, do you know if this is the best way to fix this? All
> > these various paused states on AnimationBase are very confusing for me :/
> 
> Me too, hence my caveat on your other patch. I can't easily reason about
> whether your suggested change is correct.
> 
> I think pausedness should not be a set of parallel states, but a separate
> flag on the Animation, but that's too big to do now.

The following more limited change also fixes the issue:
@@ -209,8 +209,10 @@ void ImplicitAnimation::reset(const RenderStyle& to, CompositeAnimation& composi
         Style::loadPendingResources(*m_toStyle, m_object->element()->document(), m_object->element());

     // Restart the transition
-    if (m_fromStyle && m_toStyle)
-        updateStateMachine(compositeAnimation.isSuspended() ? AnimationStateInput::PlayStatePaused : AnimationStateInput::RestartAnimation, -1);
+    if (m_fromStyle && m_toStyle) {
+        if (!compositeAnimation.isSuspended())
+            updateStateMachine(AnimationStateInput::RestartAnimation, -1);
+    }

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170613/85cba8af/attachment-0001.html>


More information about the webkit-unassigned mailing list