[Webkit-unassigned] [Bug 173266] Objects owning API clients should use UniqueRef

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173266

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 312758
  --> https://bugs.webkit.org/attachment.cgi?id=312758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312758&action=review

>> Source/WTF/wtf/UniqueRef.h:52
>> +    UniqueRef(std::unique_ptr<U>&& otherRef)
> 
> Right now a null UniqueRef is syntactically impossible to make.  This makes that not the case.  This is not what UniqueRef is supposed to be.

Well, that's why there's ASSERT(m_ref) below. I agree it would be better a compile time check. Do you have any other suggestion? or better not to use UniqueRef for the clients in the end?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170613/71eb9635/attachment.html>