[Webkit-unassigned] [Bug 173311] Do not mix C and C++ API error constants

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173311

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Alex Christensen from comment #3)
> Comment on attachment 312766 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312766&action=review
> 
> > Source/WebKit2/Shared/API/APIError.h:51
> > +    enum General {
> 
> We're trying to use more enum classes in WebKit unless there's a good reason
> not to.  And we need to be sure to have source and binary compatibility,
> which I think this patch has.

Yes, in this particular case we don't use enum class, because we are interested in the integer values, we would need to cast everywhere if we used enum class.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170613/e9591f24/attachment-0001.html>