[Webkit-unassigned] [Bug 173251] [GTK] getPage() in WebKitWebView should return a reference instead of a pointer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 12 22:34:04 PDT 2017


--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #6)
> I don't see an explanation for why signals should be disconnected before the
> object is constructed. That is unusual.

Ah! I'm sorry I thought this was the condition for connecting the signals, not to disconnect them. This is indeed a trick. Of course it can't happen, but webkitWebViewDisconnectSettingsSignalHandlers is called unconditionally in dispose, which can happen multiple times, but in dispose loaderObserer is set to nullptr, making the webkitWebViewIsConstructed false again. So this is basically preventing the signals from being disconnected more than once on destruction.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170613/59da692d/attachment-0001.html>

More information about the webkit-unassigned mailing list