[Webkit-unassigned] [Bug 171519] [PAL] Add symbol export macros for PAL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 12 12:25:24 PDT 2017


--- Comment #10 from Don Olmstead <don.olmstead at am.sony.com> ---
(In reply to Brent Fulgham from comment #9)
> Comment on attachment 312636 [details]
> WIP Patch 2
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312636&action=review
> I think the Xcode project changes look right, but I'm not sure "pal/PAL..."
> is a good naming scheme.
> > Source/WebCore/PAL/pal/crypto/CryptoDigest.h:28
> > +#include <pal/PALExportMacros.h>
> I wonder if this should be "pal/PALExportMacros.h". Seems like
> "pal/ExportMacros.h" would be enough to distinguish things.

I can change the name. It sounds better to me.

With the XCode projects there's the -DSTATICALLY_LINKED_WITH_PAL=1 that isn't there. The CryptoDigest class had no exports previously so I'm guessing things will break when there are things in PAL that were using WEBCORE_EXPORT.

I can see if I can hunt down a Mac and apply the patch to that.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170612/62f54063/attachment.html>

More information about the webkit-unassigned mailing list