[Webkit-unassigned] [Bug 173261] Retry network process connection if we fail to re-establish it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 12 07:22:33 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=173261

Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312657|review?                     |review-
              Flags|                            |

--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 312657
  --> https://bugs.webkit.org/attachment.cgi?id=312657
patch

This kind of change worries me.

Adding this somewhat arbitrary "wait 1/4 second, retry 4 times" introduces a very mysterious behavior to consider and maintain going forward.

Re-establishing the network process connection should succeed the first time.
If it doesn't, that's the bug we should fix.

You mention the problem "might be transient"? Have you shown this patch to actually produce results in practice?

If so, I think we should be much more interested in why it fails the first time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170612/d3b7539d/attachment.html>


More information about the webkit-unassigned mailing list