[Webkit-unassigned] [Bug 173251] [GTK] getPage() in WebKitWebView should return a reference instead of a pointer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173251

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 312645
  --> https://bugs.webkit.org/attachment.cgi?id=312645
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312645&action=review

Nice!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:517
>  static void webkitWebViewDisconnectSettingsSignalHandlers(WebKitWebView* webView)
>  {
> +    if (!webkitWebViewIsConstructed(webView))
> +        return;

Can this really ever be legitimately called before the WebKitWebView is constructed? It seems like you should be able to use an ASSERT here instead of an early return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170612/237d437e/attachment-0001.html>