[Webkit-unassigned] [Bug 173140] [GTK] Remove WKFullScreenClientGtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 10 01:21:33 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=173140

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 312407 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312407&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:311
> > +    if (WEBKIT_IS_WEB_VIEW(m_viewWidget))
> > +        webkitWebViewEnterFullScreen(WEBKIT_WEB_VIEW(m_viewWidget));
> > +    else
> > +        webkitWebViewBaseEnterFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget));
> 
> What... what could be a WebKitWebViewBase but not a WebKitWebView...?

C API WKView, that's why we have WebKitWebViewBase. It's used by WTR and C API unit tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170610/278fa9f8/attachment-0001.html>


More information about the webkit-unassigned mailing list