[Webkit-unassigned] [Bug 173094] [GTK] Get rid of custom marshallers of signals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173094

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 312293
  --> https://bugs.webkit.org/attachment.cgi?id=312293
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312293&action=review

Informal r+ from me.

There is a chance that the generic libffi-based marshaller is slower than the
custom ones, but it should not be much of an issue because other parts of the
WebKit code (e.g. rendering) have more weight on CPU usage. And it is nice to
have code getting removed \o/

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:87
> +        g_cclosure_marshal_generic,

You could as well pass “nullptr” here. According to the documentation for “g_signal_new()”
(https://developer.gnome.org/gobject/stable/gobject-Signals.html#g-signal-new):

> If c_marshaller is NULL, g_cclosure_marshal_generic() will be used as the
> marshaller for this signal.

And the same goes to the other changed locations. I have no strong opinion about whether
passing “g_cclosure_marshal_generic” or “nullptr” should be preferred, so I'd leave it
up to you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170608/93310a4d/attachment.html>