[Webkit-unassigned] [Bug 173093] Gardening, fix more specific linter error

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 8 05:53:35 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=173093

--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 312291
  --> https://bugs.webkit.org/attachment.cgi?id=312291
Patch

Note that to fix those warnings, usually what should be done is not to remove the expectation for Debug builds, but make the generic one be specific to Release:

--- a/LayoutTests/platform/gtk/TestExpectations
+++ b/LayoutTests/platform/gtk/TestExpectations
@@ -994,7 +994,7 @@ webkit.org/b/141700 fast/dom/Element/getClientRects.html [ Failure ]
 webkit.org/b/141700 fast/dom/Range/getClientRects.html [ Failure ]

 webkit.org/b/141705 media/video-fullscreeen-only-controls.html [ Failure ]
-webkit.org/b/141709 http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html [ Failure ]
+webkit.org/b/141709 [ Release ] http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html [ Failure ]
 webkit.org/b/141709 http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW.html [ Failure ]

 webkit.org/b/141831 svg/animations/animate-text-nested-transforms.html [ Failure ]



However, in this case you comment that it not longer crashes on Debug builds, so then is right to just remove the expectation for Debug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170608/45c86497/attachment.html>


More information about the webkit-unassigned mailing list