[Webkit-unassigned] [Bug 173084] IsInShadowTreeFlag does not get updated for a non-container node

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 7 20:00:02 PDT 2017


--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Daniel Bates from comment #2)
> Comment on attachment 312265 [details]
> Fixes the bug
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312265&action=review
> > Source/WebCore/ChangeLog:9
> > +        As a result IsInShadowTreeFlag could have gotten out-of-date when a node was inserted or removed from a shadow root
> I take it there is no observable behavior when this flag becomes
> "out-of-date" as this patch does not include a test case?

There is with the assertion I'm adding. The whole point of this patch is to add that assertion.

> > Source/WebCore/ChangeLog:12
> > +        Fixed this inconsistency by always falling insertedInto and removedFrom on all nodes.
> This sentence does not read well.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170608/626bbea7/attachment.html>

More information about the webkit-unassigned mailing list