[Webkit-unassigned] [Bug 170105] FreeBSD ar command doesn't support response files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170105

Loïc Yhuel <loic.yhuel at softathome.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |loic.yhuel at softathome.com

--- Comment #17 from Loïc Yhuel <loic.yhuel at softathome.com> ---
(In reply to Ting-Wei Lan from comment #7)
> (In reply to Michael Catanzaro from comment #6)
> > Then again, if the build works without response files, and response files
> > are broken on so many platforms, maybe we should just get rid of them?
> 
> Response files were added in bug 129771 to avoid 'Argument list too long'
> error, but we don't know which platform really requires them. If there are
> only a few platforms requiring response files, maybe we can disable them by
> default and only enable them for these specific platforms?


Actually the "argument list too long" issue was probably specific to Linux, and fixed in CMake 3.2 (https://cmake.org/Bug/view.php?id=14892). CMake already used response files when needed, but the limit was wrong on Linux.
So so we don't need to force response files any more.

CMake 3.6 added response file support for compile rules (which created https://bugs.webkit.org/show_bug.cgi?id=168770).

FreeBSD probably wasn't affected by the original issue, but even without CMAKE_NINJA_FORCE_RESPONSE_FILE, CMake will use a response file if the command line is larger than sysconf(_SC_ARG_MAX) on FreeBSD.
So if the linker (or ar) command line becomes too long, there would be an issue.

Btw, this commit disabled the response files with FreeBSD ar, but only for CMake >= 3.6, so the issue would remain for older versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170607/5f13da04/attachment.html>