[Webkit-unassigned] [Bug 172993] New: [GTK][Wayland] Do not pass value of $DISPLAY to wl_display_connect()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 6 09:32:33 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=172993

            Bug ID: 172993
           Summary: [GTK][Wayland] Do not pass value of $DISPLAY to
                    wl_display_connect()
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com
                CC: bugs-noreply at webkitgtk.org

Currently “Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp” reads:

  std::unique_ptr<PlatformDisplay> PlatformDisplayWayland::create()
  {
      struct wl_display* display = wl_display_connect(getenv("DISPLAY"));
      if (!display)
          return nullptr;

      return std::make_unique<PlatformDisplayWayland>(display, NativeDisplayOwned::Yes);
  }


The “DISPLAY” environment variable is typically used for X11, and “WAYLAND_DISPLAY”
should be used instead. According to the documentation, “wl_display_connect()” will
check the value of “WAYLAND_DISPLAY” itself, so it looks like we could just pass a
null pointer to it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170606/ebd617b3/attachment-0001.html>


More information about the webkit-unassigned mailing list