[Webkit-unassigned] [Bug 172849] REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172849

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #6 from Darin Adler <darin at apple.com> ---
(In reply to Alexey Proskuryakov from comment #3)
>          Vector<String> filenames;
>          for (NSURL *url in URLs)
> -            filenames.append(url.fileSystemRepresentation);
> +           
> filenames.append(String::fromUTF8(url.fileSystemRepresentation));

I have said before that if we want to make a String, we probably don’t want use -[NSURL fileSystemRepresentation]. I believe we can use either -[NSURL path] or CFURLCopyFileSystemPath instead to avoid the encoding/decoding process.

Alexey, Andy, did you decide you disagree with me on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170606/b1733d9a/attachment.html>