[Webkit-unassigned] [Bug 172841] Fix MotionMark to work in Internet Explorer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 5 17:33:53 PDT 2017


--- Comment #9 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 311844
  --> https://bugs.webkit.org/attachment.cgi?id=311844

View in context: https://bugs.webkit.org/attachment.cgi?id=311844&action=review

>>> PerformanceTests/MotionMark/tests/master/resources/image-data.js:42
>>> +        var nameExtension = Utilities.isInternetExplorer() ? "100.png" : ".svg";
>> It seems like it would be better to have the test be consistent across browsers, so why not have everyone one use 100.png? 
>> Also, modern convention says you should do detection, not sniffing, so if you want to keep the svg in one, png in another, you should replace the Utilities.isInternetExplorer() check, with a Utilities.canDrawSVGToCanvasWithoutTainting() check, which does that, and checks for an exception. That way, if IE changes, it will get the desired behavior.
>> That said, I think having everyone do the same thing is better.
> I implemented Utilities.canDrawSVGToCanvasWithoutTainting() which detects whether the browser throws an exception when calling getImageData() after drawing an SVG on the canvas. Beside the ones we are working around here, IE has other limitations. For example the Focus test does not work correctly because it does not render the blur filter correctly. Another limitation is data uri image has to be in url format.
> I think we need to draw the SVG images in this test since this test is the only one that loads and renders SVG images in MotionMark master suite. If we make all the browser uses the png images, no test in MotionMark will be exercising the SVG code path. I think also we should not limit ourselves to IE bugs/limitations especially Safari, Chrome and FireFox behave the same but IE does not.

I was wrong when I said "this test is the only one that loads and renders SVG images in MotionMark master suite." Actually Suits test does render SVG images also.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170606/d03a7330/attachment.html>

More information about the webkit-unassigned mailing list