[Webkit-unassigned] [Bug 172841] Fix MotionMark to work in Internet Explorer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172841

--- Comment #2 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 311784
  --> https://bugs.webkit.org/attachment.cgi?id=311784
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311784&action=review

> PerformanceTests/MotionMark/tests/master/resources/image-data.js:40
> +        var nameExtension = Utilities.isInternetExplorer() ? "100.png" : ".svg";

Comment please.

> PerformanceTests/MotionMark/tests/master/resources/leaves.js:37
> +            if (this._position.x < 0)

I think we can simplify this logic. |size.width| and |stage.size.width| is always positive. So I think we can get rid of this second if:

if (this._position.x < -this.size.width)
    this._position.x += ...
else if ( this._position.x > this.stage.size.width)
    this._position.x -= ....

> PerformanceTests/MotionMark/tests/master/resources/leaves.js:38
> +                this._position.x += (this.size.width + this.stage.size.width);

Please remove parens.

> PerformanceTests/MotionMark/tests/master/resources/leaves.js:40
> +                this._position.x -= (this.size.width + this.stage.size.width);

Ditto.

> PerformanceTests/MotionMark/tests/master/resources/leaves.js:-118
> -        particle.element.remove();

Can we polyfill this instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170602/2ac6d785/attachment.html>