[Webkit-unassigned] [Bug 174863] WebDriver: use in-view center point for clicks instead of bounding box center point

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174863

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316772|review+                     |review-
              Flags|                            |

--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 316772
  --> https://bugs.webkit.org/attachment.cgi?id=316772
Try to fix mac builds

View in context: https://bugs.webkit.org/attachment.cgi?id=316772&action=review

> Source/WebCore/page/FrameView.h:476
> +    WEBCORE_EXPORT FloatSize documentToClientOffset() const;

I would prefer not to export this, but to export something that does the coordinate conversion you want (which I think is "client to contents point").

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:553
> +        centerPoint.move(-clientOffset);
> +        inViewCenter = WebCore::IntPoint(centerPoint);
> +
> +        if (useViewportCoordinates)
> +            inViewCenter = coreFrameView->contentsToRootView(inViewCenter.value());
> +    }

I'm not sure this is correct with page scale and page zoom. It's also worth testing in an RTL document.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170731/98872e58/attachment-0001.html>