[Webkit-unassigned] [Bug 174206] [PAL] Move SPI directory into PAL

Mon Jul 31 07:55:01 PDT 2017

https://bugs.webkit.org/show_bug.cgi?id=174206

--- Comment #11 from Build Bot <buildbot at hotmail.com> ---
Attachment 316780 did not pass style-queue:

ERROR: Source/WebCore/PAL/pal/spi/ios/LaunchServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:42:  _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkConnectionCacheSPI.h:43:  _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/LookupSPI.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:129:  The parameter name "allocator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:130:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOSurfaceSPI.h:140:  The parameter name "accelerator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOPMLibSPI.h:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSPopoverSPI.h:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSURLDownloadSPI.h:66:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:114:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:115:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/pthreadSPI.h:33:  pthread_set_fixedpriority_self is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:37:  "PassKit/PassKit.h" already included at Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:30  [build/include] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:64:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:70:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:73:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/ios/MobileGestaltSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:209:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:235:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:74:  The parameter name "run" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:75:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "provide" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:77:  The parameter name "dispose" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h:133:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:37:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:58:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:61:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:63:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:66:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:72:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:73:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:74:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:75:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:76:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:77:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:78:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:79:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:80:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:81:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:92:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:114:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:115:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSScrollerImpSPI.h:116:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOTypesSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/mac/NSSharingServiceSPI.h:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:186:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:196:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:203:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:212:  Should not have spaces around = in property attributes.  [whitespace/property] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:39:  mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:40:  mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:41:  mach_vm_map is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:42:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:43:  mach_vm_protect is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:44:  mach_vm_region is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:46:  mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/MachVMSPI.h:47:  mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "cid" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "windowCount" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:219:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cf/CFLocaleSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:37:  name_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:49:  bootstrap_look_up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/ServersSPI.h:50:  bootstrap_register2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/PAL/pal/spi/cocoa/IOReturnSPI.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 91 in 256 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170731/1658b866/attachment-0001.html>