[Webkit-unassigned] [Bug 174206] [PAL] Move SPI directory into PAL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 31 07:28:48 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174206

--- Comment #7 from Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa at sony.com> ---
What I did to create the patch were:

1. git mv Source/WebCore/platform/spi Source/WebCore/PAL/pal/
2. modify the WebCore/PAL Xcode projects
3. Generate a script to fix the paths ("Foo.h" -> <pal/spi/bar/Foo.h>)
git diff -M HEAD | sed -n '/^rename from/{h;d;};/^rename to/{H;g;s/\n/ /;p;d;}' | sed 's#rename from .*\/\(.*\) rename to Source\/WebCore/\PAL\/\(.*\)#\1 \2#' |
awk '{key=$1; gsub(/\./, "\\\.", key); printf "grep \"%s\" Source -rl --include=\"*.h\" --include=\"*.c\" --include=\"*.cpp\" --include=\"*.m\" --include=\"*.mm\"", key; printf " | "; printf "xargs sed -e \047s#[\"|<]\\(\S+\/\\)*%s[\"|>]#<%s>#\047 -i \047\047\n", key, $2, key, $2}'
4. Run the generated script
5. Fix include order by clang-format-diff:
 git diff -U0 --no-color HEAD^ | clang-format-diff -i -p1 -style WebKit
6. Fix style errors (SPI headers remain untouched)

Also CMake scirpts to copy forwarding headers has been added (PAL/pal/Platform*Win*.cmake).

I tried the cmake build on mac but failed...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170731/d0dd1ff3/attachment.html>


More information about the webkit-unassigned mailing list