[Webkit-unassigned] [Bug 174787] Icon loader error on startup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174787

Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316375|review?                     |review+
              Flags|                            |

--- Comment #13 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 316375
  --> https://bugs.webkit.org/attachment.cgi?id=316375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316375&action=review

> Source/WebKit/UIProcess/API/glib/WebKitIconLoadingClient.cpp:39
> +        // WebCore can send non HTTP icons only when it doesn't find icons in document and
> +        // falls back to document-url/favicon.ico. We don't want non HTTP icons in that case either.

This comment will be outdated soon and I likely won't know to update it.

You might just want to mention non-HTTP icons, full stop, and not reference the default favicon case that exists today.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170725/6f3234f0/attachment-0001.html>