[Webkit-unassigned] [Bug 174787] Icon loader error on startup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174787

--- Comment #7 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 316361
  --> https://bugs.webkit.org/attachment.cgi?id=316361
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316361&action=review

> Source/WebCore/loader/DocumentLoader.cpp:1617
> +    if (!m_frame->isMainFrame())
> +        return;

This check is good.

> Source/WebCore/loader/DocumentLoader.cpp:1620
> +    if (document->url().isEmpty() || document->url().isBlankURL())
> +        return;

This check is good.

> Source/WebCore/loader/DocumentLoader.cpp:1627
> +        if (iconURL.protocolIsInHTTPFamily())

This will break an API test.

I know this check was in IconController before, but the new client interface is more permissive. If you don't want a non-http default favicon please make the check in your client (e.g. your API-layer icon database)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170725/d228d330/attachment.html>