[Webkit-unassigned] [Bug 174815] [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 25 04:23:06 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174815

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clopez at igalia.com
 Attachment #316362|review?                     |review+
              Flags|                            |

--- Comment #2 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 316362
  --> https://bugs.webkit.org/attachment.cgi?id=316362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316362&action=review

> Tools/ChangeLog:10
> +        ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
> +        use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes

I think the patch is fine for fixing this issue now,

But I suggest to clarify on the bug of the rename if not applying the webkit2->webkit and webkit->webkitlegacy renaming also on the directories Tools/TestWebKitAPI/Tests was intentional or an overlook.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170725/e5fc2073/attachment-0001.html>


More information about the webkit-unassigned mailing list