[Webkit-unassigned] [Bug 174670] WebDriver: wait until navigation is complete before running new commands and after a click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174670

--- Comment #14 from Brian Burg <bburg at apple.com> ---
(In reply to Carlos Garcia Campos from comment #13)
> (In reply to Brian Burg from comment #12)
> > Comment on attachment 315976 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=315976&action=review
> > 
> > >>> Source/WebDriver/ChangeLog:15
> > >>> +        6.3 Processing Model. Step 7. Wait for navigation to complete. If this returns an error return its value and
> > >> 
> > >> Nit: step 6
> > >> 
> > >> This suggests that we should be waiting for navigations to complete after any command. Should this be extracted out of particular Session methods, then?
> > > 
> > > hmm, are you using an old version of the spec or something? This is Section 6.3 and the step is indeed 7. And it suggests we should be waiting for navigations *before* any command, step 8 is "Let response result be the return value obtained by running the remote end steps for command with url variables as arguments." I added this for some of the commands only, though, I don't think we want to wait for any navigation to get the window handles, for example, but we want for sure before getting the page title.
> > 
> > I asked the spec editors, and they haven't updated the W3C copy of the CR in
> > months. You should refer to the latest editor draft here.
> > https://w3c.github.io/webdriver/webdriver-spec.html
> 
> Oh, I had no idea :-( I assumed w3c was up to date. Now I understand the new
> request queue thing you were talking about. But I don't understand the spec,
> though, so we queue the request, wait for it to reach the queue and then we
> dequeue it?

Basically, multiple clients could send REST API requests to the same session concurrently. The command queue forces these to be handled serially in FIFO order. Obviously, if you only use one serial queue to handle incoming HTTP requests, then there's nothing to do. However, most web servers use concurrent queues/threads, so you may need to do some queueing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170724/332ae1d2/attachment.html>