[Webkit-unassigned] [Bug 174788] [GTK] ASSERTION FAILED: client in WebKit::IconDatabase::setClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174788

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #1 from Michael Catanzaro <mcatanzaro at igalia.com> ---
We have:

void IconDatabase::setClient(std::unique_ptr<IconDatabaseClient>&& client)
{
    // We don't allow a null client, because we never null check it anywhere in this code
    // Also don't allow a client change after the thread has already began
    // (setting the client should occur before the database is opened)
    ASSERT(client);
    ASSERT(!m_syncThreadRunning);
    if (!client || m_syncThreadRunning)
        return;

    m_client = WTFMove(client);
}

And:

struct _WebKitFaviconDatabasePrivate {
    ~_WebKitFaviconDatabasePrivate()
    {
        iconDatabase->setClient(nullptr);
    }

    // ...
};

I guess we have to null-check client everywhere. That's not so hard.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170724/c9208b73/attachment.html>