[Webkit-unassigned] [Bug 174760] [GTK] Icon database error and crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 24 08:04:23 PDT 2017


--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 316273
  --> https://bugs.webkit.org/attachment.cgi?id=316273

View in context: https://bugs.webkit.org/attachment.cgi?id=316273&action=review

I'm not sure I understand this fix. Is your goal to prevent the crash by ensuring that IconDatabase::performReleaseIconForPageURL is never called ever? That is quite a hack, but I think that's fine as you say you're planning to delete all this code, and I'm confident that will happen sooner rather than later. The IconDatabase has always been a mess anyway.

I will test the change to see if it works... building now.

> Source/WebKit/UIProcess/API/glib/IconDatabase.cpp:123
>      // It's okay to delete the raw image here. Any existing clients using this icon will be
>      // managing an image that was created with a copy of this raw image data.

Um... I'm not sure if this comment is really supposed to be in this function at all... but I would have added your new conditional above it rather than below it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170724/7b7910ca/attachment.html>

More information about the webkit-unassigned mailing list