[Webkit-unassigned] [Bug 174760] [GTK] Icon database error and crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 24 00:57:07 PDT 2017


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |cgarcia at igalia.com

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
I think this problem has always existed, but before removing the code, history items were retaining icons preventing them from being deleted in some cases. IconRecord and PageURLRecord objects can be created and destroyed either in sync or main thread. The problem seems to be the frame timer of the BitmapImage, that is not even used nor needed at all. We currently retain icons when they are returned by webkit_favicon_database_get_favicon(), but we release them if we fail to get them. I guess this crash happens for a page that doesn't have a favicon. I don't think it's worth trying to fix the IconDatabase mess, because we will eventually replace it, hopefully during the next cycle. So, for now, I think we can simple change IconRecord::setImageData() to not create the image if the given data is nullptr.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170724/00fc86d2/attachment-0001.html>

More information about the webkit-unassigned mailing list