[Webkit-unassigned] [Bug 174775] New: REGRESSION(r219657): Broke style checker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 24 00:37:42 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174775

            Bug ID: 174775
           Summary: REGRESSION(r219657): Broke style checker
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: rego at igalia.com
                CC: aakash_jain at apple.com, ddkilzer at webkit.org,
                    jbedard at apple.com, lforschler at apple.com
        Depends on: 173559

After r219657 (bug #173559) we're getting a weird style checker error in some patches:
* https://bugs.webkit.org/show_bug.cgi?id=174675#c5
* https://bugs.webkit.org/show_bug.cgi?id=174451#c29

Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 155, in main
    patch_checker.check(patch)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=None)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 119, in process_file
    self._files[abs_file_path] = self._files[abs_file_path] + kwargs['line_numbers']
TypeError: can only concatenate list (not "NoneType") to list


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=173559
[Bug 173559] lint-test-expectations should be run during style checking
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170724/f813b7db/attachment.html>


More information about the webkit-unassigned mailing list