[Webkit-unassigned] [Bug 174762] New: B3 should have a reusable EffectsSet data structure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174762

            Bug ID: 174762
           Summary: B3 should have a reusable EffectsSet data structure
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

Currently there are a couple places (eliminateCommonSubexpressions and hoistLoopInvariantValues) that both construct a data structure that tracks the set of effects.  When we are just tracking heap ranges, then a RangeSet<> will do.  But sometimes we want to track that and the other things (control dependence, side exiting, things done to local state, etc).  We basically want a version of Effects that tracks the set of effects: so the same boolean fields, but RangeSet<HeapRange> for reads/writes.

This would make some code a bit less yucky and a considerably less error-prone.  It ought to be perf neutral, too (it just means flipping a handful more booleans).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170723/03e65adb/attachment-0001.html>