[Webkit-unassigned] [Bug 174672] WebDriver: implement page load timeout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174672

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Joseph Pecoraro from comment #2)
> Comment on attachment 315982 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315982&action=review
> 
> Nice! I'll let Brian review. If I remember correctly this could address a
> number of the failures in the Selenium test suite that expected some timeout.

Not really, only the two tests I mentioned before set a page load timeout:

$ git grep set_page_load_timeout
page_load_timeout_tests.py:    driver.set_page_load_timeout(0.01)
page_load_timeout_tests.py:    driver.set_page_load_timeout(0.01)

And the default timeout is so long (300 seconds) that it doesn't affect any other test.

> > Source/WebDriver/ChangeLog:9
> > +        commands. Also fix the setTimeouts command that was still using the legacy name of rthe page load timeout,
> 
> Typo: "of rthe" => "for the"

Oops, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170721/331ccdf0/attachment-0001.html>