[Webkit-unassigned] [Bug 174445] Add WebDriver support in browser driver part of BenchmarkRunner

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 18 14:21:37 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174445

dewei_zhu at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dewei_zhu at apple.com

--- Comment #8 from dewei_zhu at apple.com ---
Comment on attachment 315726
  --> https://bugs.webkit.org/attachment.cgi?id=315726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315726&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:22
> +    def launch_driver(self, url, driver):
> +        pass

This function name is ambiguous with 'launch_driver(self, url, options, browser_build_path)'.

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:43
> +        raise ValueError("Browser \"%s\" is not available with webdriver" % self.browser_name)

str.format is preferred.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170718/79935e49/attachment-0001.html>


More information about the webkit-unassigned mailing list