[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to Frederik Riedel from comment #7)
> I am not really sure about some comments of the style checker:
> 
> ERROR: Source/WebKit2/UIProcess/ios/WKContentView.mm:634:  This { should be
> at the end of the previous line  [whitespace/braces] [4]
> 
> Don't we put { in new lines in WebKit?
> This is probably more about the missing space before (BOOL), right?
> -(BOOL)acceptsAutofilledLoginCredentials

That's probably right -- I check-webkit-style is just getting confused here.

> 
> 
> ERROR: Source/WebKit/mac/DOM/DOMHTMLInputElement.h:28:  Alphabetical sorting
> problem.  [build/include_order] [4]
> 
> Where do I need to put this import to make it alphabetically correctly? How
> are @class and import<> and import"" considered?

This needs to be wrapped in a TARGET_OS_IPHONE anyways, I think if you do that the style queue won't complain about the ordering because platform specific headers go afterwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170718/a84ff900/attachment.html>