[Webkit-unassigned] [Bug 174530] Add performance.mark()s around Speedometer test steps

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 18 11:42:08 PDT 2017


--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 315805
  --> https://bugs.webkit.org/attachment.cgi?id=315805

View in context: https://bugs.webkit.org/attachment.cgi?id=315805&action=review

Thanks for the patch.

> PerformanceTests/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=174530

This URL should appear right below the it title.

> PerformanceTests/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

Followed by this line, and then the long description you have above.
See other entries for the format.

> PerformanceTests/Speedometer/resources/benchmark-runner.js:116
> +    if (window.performance && window.performance.mark) { window.performance.mark(name); }

Please put the call to mark in a separate line with an indentation but without curly braces to match the WebKit coding style.

> PerformanceTests/Speedometer/resources/benchmark-runner.js:252
> +        self._runTest(`${suite.name}.${test.name}`, suite, test.run, self._prepareReturnValue, function (syncTime, asyncTime) {

I think it’s cleaner to pass in the test object, and construct the string in _runTrst function.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170718/93420ca1/attachment.html>

More information about the webkit-unassigned mailing list